since we're not linking anymore, update BPM pictures on manual pictur…

[kongomongo]

…e selection. Also fixes BPM pictures on type 'other' (manually added to Steam)

[lolcatplays]

Hey could you send me a build with that fix? This has been nagging me for ages

[SantaHey]

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull #135

I publish a built version with this fix and another if you want to install it
The link is available in this issue : #130

[lolcatplays]

Thank you SO much

[kongomongo]

Hey could you send me a build with that fix? This has been nagging me for ages

@lolcatplays I adapt the code of @kongomongo and fix this issue in a new pull #135

I publish a built version with this fix and another if you want to install it
The link is available in this issue : #130

Strange, I never ran into that problem myself using master.

I use Steam/non-Steam, gog, etc... all without problems.

Can you show an example where the current master fails?

[SantaHey]

Can you show an example where the current master fails?

I downloaded the master and added this code in Steam.js/getNonSteamGames() at line 151
log.info("\n---Name : "+ item.appName);
log.info("appId from shortcuts.vdf: "+ item.appid);
log.info("appId with bitwise unsigned 32bit: "+ (item.appid >>> 0));
log.info("Generated OldAppId : "+ this.generateAppId(exe, appName));
log.info("Generated NewAppID : "+ this.generateNewAppId(exe, appName));

Result :
generateNewAppId() is the actual function used by SteamGridDB Manager and it's working only for games imported by SteamGridDB

If I set my image with SteamGridDB it doesn't update in Steam and if I set manually it generates a file with appid from shortcuts.vdf that isn't corresponding to generateNewAppId() result

[kongomongo]

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

[SantaHey]

You are correct, generateNewAppId fails for manually added non-steam games. The question remains: why?

I think Steam generate a random id for every new non-steam game imported.

Example with the exact same executable, it generates each time a different.