-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker build on BuildKit (now the default on Actions runners) #5
base: main
Are you sure you want to change the base?
Fix docker build on BuildKit (now the default on Actions runners) #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments, not directly approving but not explicitly requiring the version detection change
7bbdd30
to
d0fcbd7
Compare
d0fcbd7
to
c75ebd4
Compare
Hey @AAGaming00, it seems like Valve updated the API to actually contain image versions now, so I went ahead and implemented that change, and rebased onto the latest Since 3.5.7 is out on stable now I suppose that building that might be a good test of the changes? |
This may be easiest to review commit-by-commit, particularly the Dockerfile. I tested the build on my fork with my own credentials to make sure everything was working as well.
Changes:
filesystem
due to BuildKit builds (via Docker) are broken if /etc/hosts or /etc/resolv.conf is replaced moby/buildkit#1267mesa-unstable
to the list of removed packages, it had some dependencies on other packages that are being removed