Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decky-zerotier v0.3.0 #711

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add decky-zerotier v0.3.0 #711

wants to merge 3 commits into from

Conversation

hyacz
Copy link

@hyacz hyacz commented Oct 18, 2024

Decky Zerotier

https://github.com/hyacz/decky-zerotier
#665

This plugin is a Zerotier client UI designed for SteamDeck to support the LAN connection function of some games.

Compared to v0.1.0, the Zerotier core binary has been upgraded from v1.14.0 to v1.14.1, and it is now built using Github action.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • Yes: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review was simple as it's just a few more additions to the original submission. In future please include a link to the comparison between your original PR and this one (commit wise) so I can review the changes between then and now.
Good for testing again.

@TrainDoctor TrainDoctor requested review from a team October 22, 2024 18:21
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely missed this, this won't be caught and built by CI until the git submodule is fixed.

.gitmodules Outdated Show resolved Hide resolved
@TrainDoctor
Copy link
Member

@hyacz this one is on me, the plugin is also located in "plugins/plugins" which is incorrect and needs to be fixed as well.

@hyacz
Copy link
Author

hyacz commented Oct 23, 2024

Sorry, I made a mistake, I am not familiar with PR process. I used a force push to make the Commit Message easier to read, I hope this will not cause more problems.

@hyacz
Copy link
Author

hyacz commented Oct 23, 2024

I re-corrected the submodule so that it now correctly points to decky zerotier tag v0.2.0

@TrainDoctor TrainDoctor dismissed their stale review October 23, 2024 14:49

Stale, submodule issues fixed.

@TrainDoctor TrainDoctor requested a review from a team October 23, 2024 14:49
@hyacz
Copy link
Author

hyacz commented Oct 26, 2024

hyacz/decky-zerotier@v0.2.0...v0.2.1

@hyacz hyacz changed the title Add decky-zerotier v0.2.0 Add decky-zerotier v0.2.1 Oct 26, 2024
@hyacz
Copy link
Author

hyacz commented Nov 20, 2024

hyacz/decky-zerotier@v0.2.1...v0.3.0

  • Updated Zerotier from v1.14.1 to v1.14.2
  • Updated dependency packages

@hyacz hyacz changed the title Add decky-zerotier v0.2.1 Add decky-zerotier v0.3.0 Nov 20, 2024
@hyacz hyacz requested a review from TrainDoctor November 25, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants