Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS3 QuickAccess to v1.1.2 #470

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Conversation

ILadis
Copy link
Contributor

@ILadis ILadis commented Nov 4, 2023

TS3 QuickAccess

This update includes a critical bugfix for my plugin. Prior to this release on some Steam Decks TeamSpeak couldn't be launched in the background which rendered the plugin non functional. There is a lengthy discussion about this issue here.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • Yes: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

The fix was thoroughly tested by @DSKB823 (see the issue mentioned above).

@TrainDoctor
Copy link
Member

Code review looks good, sending to testing.

@TrainDoctor TrainDoctor requested a review from a team November 4, 2023 22:39
@TrainDoctor
Copy link
Member

TrainDoctor commented Nov 4, 2023

@ILadis please have @DSKB823 provide feedback according to this page: https://deckbrew.xyz/testing#

@ILadis
Copy link
Contributor Author

ILadis commented Nov 5, 2023

@TrainDoctor: the link is not working for me (I'm getting a page not found error), but you are probably referring to this page.

@DSKB823: you are now able to install version 1.1.2 from the testing store. There is a guide on how to do that here. It would be great if you could test the version from the testing store as well and provide feedback according to that page.

@Banyyk
Copy link

Banyyk commented Nov 5, 2023

@TrainDoctor: the link is not working for me (I'm getting a page not found error), but you are probably referring to this page.

@DSKB823: you are now able to install version 1.1.2 from the testing store. There is a guide on how to do that here. It would be great if you could test the version from the testing store as well and provide feedback according to that page.

i was one of the people who had this problem and tested the plugin from the store. i used the latest (beta) decky version also as the latest SteamOS Version. I can say that it works now as intended! thanks for you work!

also i checked if i can give a review but i havent found anything where i can submit it unter here

@DSKB823
Copy link

DSKB823 commented Nov 5, 2023

Test was done on Decky version 2.10.5, SteamOS version: 3.4.11

A) no major issues encountered
B) no note worthy minor issues encountered
C) Installed Plugins:

  • TS3 Quickaccess 1.1.2-edbfde5 (the plugin I'm testing and review right now)
  • Volume Mixer -1.2.1
  • Notebook - 0.1.4-1
  • Bluetooth - 2.1.0
  • RadiYo! - 1.2.1
  • ProtonDB Badges - 1.0.11
  • MangoPeel - 0.0.4
  • SteamGridDB - 1.3.1
  • TabMaster - 2.1.0
  • Animation Changer - 1.3.0-1
  • Audio Loader - 1.5.1
  • PowerTools - 1.4.0
  • System Toolbox - v1.0.2-1

D) Yay, ready for the store

I hope I didn't miss anything necessary for my Test Report. In case this is relevant: Time spent testing > 12 hours
Also this is the right place for this report isn't it?

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSKB823 thanks for the excellent report.
Good to go to production.

@TrainDoctor TrainDoctor merged commit 3aa9c62 into SteamDeckHomebrew:main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants