-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NonSteamLaunchers #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove dist from your repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/moraroy/NonSteamLaunchersDecky/blob/main/src/index.tsx#L32
consider just passing the object as the second argument, it's faster
https://github.com/moraroy/NonSteamLaunchersDecky/blob/cd8a51852b2daa265aaf4c4047c52f9566a33752/src/index.tsx#L180
did you test this? iirc alert doesn't work on steam deck (and used to cause issues)
https://github.com/moraroy/NonSteamLaunchersDecky/blob/cd8a51852b2daa265aaf4c4047c52f9566a33752/src/index.tsx#L297
What is this still doing there
https://github.com/moraroy/NonSteamLaunchersDecky/blob/cd8a51852b2daa265aaf4c4047c52f9566a33752/src/index.tsx#L360
don't style entire element types globally, your styles can collide. if you must do this (and if you must use decky- classes) then wrap your entire panel in a class and use that as the root of the selector so they do not apply globally
you also need to include the original template license text with your repo in addition to yours
Please update your PR to include a description of what your plugin does and why. Thanks. |
@TrainDoctor @AAGaming00 thanks, i took a break from coding these past couple weeks, will be making the necessary changes in the coming week or two. Also, @AAGaming00 i was using the alerts to help me "log" what the plugin was doing, it works fine for me i havnt run into any problems using it tbh |
@AAGaming00 @TrainDoctor i made all the necessary changes you guys said to my main plugin repo. ive also left some code in their and commented out some that i will work on in the future but as of right now ive tested the plugin and it works. How do i update this pull request to update the sub module again? |
Apologies for not giving advice earlier but you've updated every single submodule instead of just yours. You will need to revert to your previous commit of the repo and only update your submodule. Thanks. |
I have no idea what happened to the repo sorry man, i think i may just redo the submodule pull request? @TrainDoctor |
NonSteamLaunchers
Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder (or separate) and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, Origin, The EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher, Glyph and Minecraft. Now with SD Card Support.
If this is an update, please include a summary of what changes you made.
[If you have not already, please read the review and testing page on the wiki. Remove this line before submitting your plugin.]
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist