Sims/pyinstaller misuse fix #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
We incorrectly use pyinstaller in some parts of decky. This PR fixes that.
For more details, see this discussion
This originally was to fix windows again, but just because it worked on linux doesn't mean these misuses shouldn't be fixed.
Note: This PR brings a massive breaking change. We handle imports properly now, which means decky plugins can no longer use decky internals in their own application. (They still kind of can, but only what is explicitly imported into sandboxed_plugin.py).
Imo it's preferrable that plugins do not use decky internals in their own plugins. I think we should reconsider this.