Get plugin name for development ZIP during installation #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrainDoctor
added
enhancement
FineWolf
reviewed
Jan 24, 2024
Signed-off-by: eXhumer <[email protected]>
Thanks for the comments regarding the plugin structure, I have amended changes based on the comments left. |
lci-andrewmoore
approved these changes
Jan 25, 2024
|
Sigh, wrong account, but yes. Looks good. |
Add another name placeholder for getting the toaster out of the HTML tree. Thanks to @eXhumer for the fix.
* Added translation using Weblate (Japanese) * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Translated using Weblate (Japanese) Currently translated at 82.7% (115 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 89.2% (124 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/ --------- Co-authored-by: Tak-attack <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Fábio Oliveira <[email protected]>
Signed-off-by: eXhumer <[email protected]>
|
@SteamDeckHomebrew/decky-testers need a tester for this one. Please install this PR's binary and then download a zip for a plugin and then rename that zip however you'd like (just don't give it the same name :P) and check that this works. |
TrainDoctor
approved these changes
Feb 15, 2024
PartyWumpus
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix: get plugin name for dev builds from ZIP (#527) Signed-off-by: eXhumer <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
Currently the development plugin installation from ZIP / URL is broken partially, due to relying on ZIP name as the plugin name. This commit fixes the issue, by parsing the plugin name from the folder containing
plugin.jsonfrom the ZIP. I tested this on my Steam Deck OLED and can confirm it to fix the issue. I installed a ZIP which previously failed installation and it now works without issue with this commit.Related comments on issue
#527 (comment)
#527 (comment)
This fixes issue: #527