Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] File picker improvements #454

Merged
merged 168 commits into from
Jun 19, 2023

Conversation

RodoMa92
Copy link
Contributor

This PR implements the additional features from @doZennn into Decky Loader, adding translation on top and adding a few features (like a nicer way to signal errors to the user and additional ways for the requester to specify if they want to allow all file types to be selected or not).

@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers please give this a go.

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mater if i choose to show only ".zip" files or not. The Filepicker always only show directorys and not individual files.

@RodoMa92
Copy link
Contributor Author

RodoMa92 commented May 30, 2023

I've fixed the issues, missed that in python splitext also return the leading dot for the extension. Now the filtering seems to work fine, hovewer the multimodal seems to not be rerendered after modifying from the filepicker, even if the selection in the filepicker UI is correct. If @doZennn can give a quick look to understand why it doesn't trigger a rerender, it would be extremely helpful.

In any case, it's just a visual bug and not a functionality bug.

Marco.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, code appears to be largely fine but I think it's important we don't use a hardcoded path. Other than that great job and once fixes are made/conflicts are resolved and this can be tested it should be good to merge.

@TrainDoctor TrainDoctor self-requested a review June 2, 2023 01:16
@RodoMa92 RodoMa92 requested a review from nabel0 June 19, 2023 07:04
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants