-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] File picker improvements #454
[Feature] File picker improvements #454
Conversation
This reverts commit 8e82319.
The button will now respect the actual maximum desired number of entries.
@SteamDeckHomebrew/decky-testers please give this a go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No mater if i choose to show only ".zip" files or not. The Filepicker always only show directorys and not individual files.
I've fixed the issues, missed that in python splitext also return the leading dot for the extension. Now the filtering seems to work fine, hovewer the multimodal seems to not be rerendered after modifying from the filepicker, even if the selection in the filepicker UI is correct. If @doZennn can give a quick look to understand why it doesn't trigger a rerender, it would be extremely helpful. In any case, it's just a visual bug and not a functionality bug. Marco. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, code appears to be largely fine but I think it's important we don't use a hardcoded path. Other than that great job and once fixes are made/conflicts are resolved and this can be tested it should be good to merge.
…loader into file_picker_improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me
This PR implements the additional features from @doZennn into Decky Loader, adding translation on top and adding a few features (like a nicer way to signal errors to the user and additional ways for the requester to specify if they want to allow all file types to be selected or not).