feat: ✨ add nestedStackedBarsVertical and confarea #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals/Scope
We have identified two opportunities to improve the SSZVIS library by incorporating commonly used features, the
nestedStackedBar
and theconfarea
. Here are the key points:heatmap
,sunburst
andpie chart
combined).confarea
).Proposed Solution
To address this, we propose:
nestedStackedBar
andconfarea
implementation directly into the SSZVIS library (bump version to 3.1.0).Additional Tasks
There are a few underlying issues with charts that are related to the old .enter().exit() pattern. We will address these issues as part of this PR by updating the code to use the new .join() pattern.
Description
Porting the
nestedStackedBar
andconfarea
features went as smooth as expected. There is now a new page for the nestedStackedBar and confarea was added to the annotation section:sszvis.nestedStackedBarsVertical
sszvis.annotationConfArea
With the
.join()
pattern there was actually a lot of places this needed to be changes and many side effects that needed to be addressed..enter()
has now been removed from the codebase and all the charts tested for visual regression and functionality.Will be good to do some more testing with all the production charts to make sure everything is working as expected.
How to Test
In order to see the charts you will need to spin up the local server and navigate to the nestedStackedBar and Annotation pages. (make sure to run
npm run build
before starting the server)24 hr
]