This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
feat: add a new setting logo_link #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for demo-staticjscms ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for staticjscms ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 55.87% 55.87%
=======================================
Files 259 259
Lines 12314 12314
Branches 3089 3089
=======================================
Hits 6880 6880
Misses 5027 5027
Partials 407 407 ☔ View full report in Codecov by Sentry. |
KaneFreeman
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added a new config
logo_linkwhich when set wraps the logo in the top left corner in an anchor/link.The link can be set to another page or to a page in cms giving you a quick access to your fav page (it is like a home button which will transfer to your index page).
In the next major version, it would be good to group
logo_urlandlogo_linkin one object/setting, likelogo: { url: "...", link: "..." }.