Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift-server: (extra-large) update dependencies, rename @creditkarma -> @statestitle #5

Merged
merged 7 commits into from
Jan 14, 2022
Merged

thrift-server: (extra-large) update dependencies, rename @creditkarma -> @statestitle #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
83d49af
update all the dependencies, clean some stuff up
Jan 13, 2022
5ddc521
update some missed dependencies; convert @creditkarma to @statestitle…
Jan 13, 2022
6da53df
fix various tests
Jan 14, 2022
1f96aa2
a couple more typos
Jan 14, 2022
edda39c
add the message field back in as required
Jan 14, 2022
d49e76b
fix some @creditkaram -> @statestitle
Jan 14, 2022
fab6135
update a couple of more transitive dependencies
Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Please take a moment to review this document to make the contribution process ea

## Reporting a bug

Thrift Server uses github issues to track bugs. Bugs are labelled as [bug](https://github.com/creditkarma/thrift-server/labels/bug).
Thrift Server uses github issues to track bugs. Bugs are labelled as [bug](https://github.com/StatesTitle/thrift-server/labels/bug).
Before reporting a new bug first search the issues to find out if it's already reported and/or resolved and pending merge.

When you create a new bug report please include following information:
Expand All @@ -14,7 +14,7 @@ When you create a new bug report please include following information:

## Feature requests

Feature requests are labelled as [enhancement](https://github.com/creditkarma/thrift-server/labels/enhancement).
Feature requests are labelled as [enhancement](https://github.com/StatesTitle/thrift-server/labels/enhancement).
We welcome new feature requests but first find out if a similar request is already in the queue.

## Pull requests (bug fix, features, etc)
Expand Down
18 changes: 9 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ To build and run `thrift-server` locally you can follow these steps.
First, clone the repo:

```sh
$ git clone https://github.com/creditkarma/thrift-server.git
$ git clone https://github.com/StatesTitle/thrift-server.git
```

Because `thrift-server` is a mono-repo containing multiple libraries, we use [lerna](https://lernajs.io/) to manage inter-dependencies. Running common `npm` commands at the project root will run these commands in all the packages.
Expand Down Expand Up @@ -119,10 +119,10 @@ Because Thrift Server is developed with TypeScript and recommended usage is with

```sh
$ npm install --save-dev typescript
$ npm install --save-dev @creditkarma/thrift-typescript
$ npm install --save @creditkarma/thrift-server-core
$ npm install --save @creditkarma/thrift-server-hapi
$ npm install --save @creditkarma/thrift-client
$ npm install --save-dev @statestitle/thrift-typescript
$ npm install --save @statestitle/thrift-server-core
$ npm install --save @statestitle/thrift-server-hapi
$ npm install --save @statestitle/thrift-client
$ npm install --save request
$ npm install --save @types/request
$ npm install --save hapi
Expand All @@ -144,7 +144,7 @@ I save this file in my project as `thrift/calculator.thrift`.

### Generating Service Code

We generate TypeScript from our Thrift IDL using [thrift-typescript](https://github.com/creditkarma/thrift-typescript). In my `package.json` I add something like this:
We generate TypeScript from our Thrift IDL using [thrift-typescript](https://github.com/statestitle/thrift-typescript). In my `package.json` I add something like this:

**v0.9.x of this library requires thrift-typescript v3.x**
**v0.7.x - 0.8.x of this library requires thrift-typescript v2.x**
Expand Down Expand Up @@ -185,7 +185,7 @@ The code to implement this service is pretty straight-forward:

```typescript
import * as Hapi from 'hapi'
import { ThriftServerHapi } from '@creditkarma/thrift-server-hapi'
import { ThriftServerHapi } from '@statestitle/thrift-server-hapi'
import { Calculator } from './generated/calculator'

const PORT: number = 8080
Expand Down Expand Up @@ -251,7 +251,7 @@ I'm adding the following code to a file called `src/client.ts`.
```typescript
import {
createHttpClient
} from '@creditkaram/thrift-client'
} from '@statestitle/thrift-client'

import { CoreOptions } from 'request'

Expand All @@ -277,7 +277,7 @@ Because we're already using Hapi, let's add this to our `src/client.ts` file:
```typescript
import {
createHttpClient
} from '@creditkaram/thrift-client'
} from '@statestitle/thrift-client'

import * as Hapi from 'hapi'

Expand Down
Loading