sync with the last credit karma changes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: bumping hapi version to support node14 upgrade * chore: fix compilation errors * chore: fixing circleCI env to use node12 and 14 * chore: fixing circleCI * v0.17.0-alpha.0 * chore: bumping hapi types to 20.x.x * chore: bumping package-lock files * chore: bumping peer versions
…into creditkarma-master
markdoliner-doma
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Credit Karma thrift-server repo had some changes to get Node 14 working, so it seems like we should merge those into our fork before doing more work. I wasn't planning on publishing this version, just getting the changes in. The
package-lock.jsonfiles were deleted on the Credit Karma repo, but I plan on recreating them soon once I've updated the dependencies and such.