change circleci/ to cimg/ #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhepler
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
We discussed this in slack - from what you said, you were able to build these images locally without issue. Given that CircleCI claims that the cimg images are similar to the circleci images and given that we have no identified current use cases for these images, I think this change looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes
statestitle/cicrclecito usecimg/instead ofcircleci/since CircleCI introduced the next generation (next-gen) of convenience images and these new images are designed to replace the legacy convenience images that were released during the announcement of CircleCIThe node images now extend the official Ubuntu image.