Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mpi 1.6 #260

Merged
merged 2 commits into from
Sep 21, 2022
Merged

upgrade mpi 1.6 #260

merged 2 commits into from
Sep 21, 2022

Conversation

rohank07
Copy link
Contributor

@rohank07 rohank07 commented Sep 21, 2022

closes #252
mpi-job has been moved into tf-training. We can get rid of the mpi-job, mx-net and pytorch component and continue to upgrade tf-training.
Ref: kubeflow/manifests#2123 (comment)
kubeflow/manifests#1962 (comment)

@rohank07 rohank07 requested a review from sylus September 21, 2022 15:43
Copy link
Member

@sylus sylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can our folder restructure also match the new naming ?

Also i have no idea what you mean remove pytorch that is a different component entirely then this P.R. addresses

Do you mean training-operator now calls all those components?

@rohank07
Copy link
Contributor Author

rohank07 commented Sep 21, 2022

Yeah v1.4 they have a universal operator that supports all frameworks, getting rid of pytorch, mxnet and xgboost operator.
Mpi-job is wrapped into tf-training

@sylus
Copy link
Member

sylus commented Sep 21, 2022

This file needs to be deleted

kustomize/apps/tf-training/base/kustomization.yaml

@sylus
Copy link
Member

sylus commented Sep 21, 2022

Sorry last thing

/training-operator/

We need to call training-operator name as well instead of tf-operator.

@sylus sylus self-requested a review September 21, 2022 17:05
@sylus sylus merged commit 3403a52 into aaw-dev-cc-00 Sep 21, 2022
@sylus sylus deleted the upgrade-mpi-1.6 branch November 5, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade 1.6 Apps: mpi-job
2 participants