Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 更正有关RGB和HSV的函数命名与描述错误 #739

Merged
merged 41 commits into from
Oct 15, 2023

Conversation

weiduhuo
Copy link
Contributor

No description provided.

Night-stars-1 and others added 30 commits October 2, 2023 02:18
Fix: 修正当大月卡按钮不存在时无法正确识别已进入地图的问题
@Night-stars-1
Copy link
Collaborator

HSV=cv.cvtColor(img,cv.COLOR_BGR2HSV)

识别使用的是hsv,当前命名没有什么太大问题

@weiduhuo
Copy link
Contributor Author

HSV=cv.cvtColor(img,cv.COLOR_BGR2HSV)

识别使用的是hsv,当前命名没有什么太大问题

你说的这个参数命名确实没有问题,但是它包含在了get_pix_rgb函数中就说明函数命名有问题了。具体看我目前PR最后一个commit:https://github.com/Starry-Wind/StarRailAssistant/pull/739/commits/d59ac8075cd1377ff415fff63887eba90cd7af2c
PR的时候不知道为什么显示了之前提交被回滚过的commit…其实对于当前PR有效的只有最后一个commit

@weiduhuo weiduhuo changed the title fix: 更正有关RGB和HSV的错误命名与描述 fix: 更正有关RGB和HSV的函数命名与描述错误 Oct 14, 2023
@Night-stars-1 Night-stars-1 merged commit eaa21c0 into Starry-Wind:main-beta Oct 15, 2023
1 check passed
@weiduhuo weiduhuo deleted the debug-rgb branch October 15, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants