Replace deep-equal with fast-deep-equal #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello/
thank you for
fast-deep-equal
I'm working on a secure build system to help prevent browserify apps from getting hacked by evil dependencies. Its based on https://github.com/Agoric/SES
Unfortunately
deep-equal
does not work in SESI tried replacing it with
fast-deep-equal
and all the tests pass just fine.Performance characteristics seem to be different, some fast and some slower.
benchmarks summary (percent change in ops/sec)
most notable:
all:
benchmark diffs are as follows: