[BugFix] Fix migrate storage medium miss auto-bucket partition bug #53101
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| @@ -1515,7 +1525,7 @@ protected static void handleMigration(ListMultimap<TStorageMedium, Long> tabletM | |||
| continue; | |||
| } | |||
|
|
|||
| if (!migratableTablet(db, table, tabletMeta.getPhysicalPartitionId(), tabletMeta.getIndexId(), tabletId)) { | |||
| if (!migrateTablet(db, table, tabletMeta.getPhysicalPartitionId(), tabletMeta.getIndexId(), tabletId)) { | |||
| continue; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The most risky bug in this code is:
There seems to be a logical inconsistency with using physicalPartitionId instead of partitionId when fetching the storage medium for migration, which might lead to incorrectly determining whether a tablet needs migration.
You can modify the code like this:
// In the context where storage medium is being checked for migration
TStorageMedium storageMedium = storageMediumMap.get(physicalPartitionId); // Change from .getParentId() to use the correct id
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 10 / 14 (71.43%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
gengjun-git
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/8844
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: