Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix disable base compaction with minute granularity & fe/be recover #52923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] Fix disable base compaction with minute granularity & fe/be recover #52923

wants to merge 1 commit into from
+269 −114

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Nov 15, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested review from a team as code owners November 15, 2024 02:48
@mergify mergify bot assigned meegoo Nov 15, 2024
wyb
wyb previously approved these changes Nov 15, 2024
View reviewed changes
@meegoo meegoo force-pushed the fix_base_disable branch 3 times, most recently from b46e2b5 to 86f5e7f Compare November 16, 2024 22:53
@meegoo meegoo requested a review from a team as a code owner November 16, 2024 22:53
@meegoo meegoo force-pushed the fix_base_disable branch 2 times, most recently from 0ae96fe to 6464275 Compare November 18, 2024 00:03
@meegoo meegoo changed the title [BugFix] Fix disable base compaction with minute granularity [BugFix] Fix disable base compaction with minute granularity & fe/be recover Nov 18, 2024
wyb
wyb previously approved these changes Nov 18, 2024
View reviewed changes
gengjun-git
gengjun-git previously approved these changes Nov 18, 2024
View reviewed changes
@meegoo meegoo enabled auto-merge (squash) November 18, 2024 02:49
kevincai
kevincai reviewed Nov 18, 2024
View reviewed changes
test/sql/test_compaction_cron/T/test_compaction_cron Outdated Show resolved Hide resolved
test/sql/test_compaction_cron/R/test_compaction_cron Outdated Show resolved Hide resolved
be/src/common/config.h Outdated Show resolved Hide resolved
be/src/storage/compaction_manager.cpp Outdated Show resolved Hide resolved
be/src/storage/tablet_meta.h Outdated Show resolved Hide resolved
@meegoo meegoo dismissed stale reviews from gengjun-git and wyb via 7d14f8f November 18, 2024 03:29
@meegoo meegoo requested a review from a team as a code owner November 18, 2024 03:29
@meegoo meegoo removed the request for review from a team November 18, 2024 03:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 18 / 19 (94.74%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/compaction_manager.cpp 17 18 94.44% [166]
🔵 be/src/storage/compaction_task.cpp 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 59 / 81 (72.84%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/AlterJobExecutor.java 0 3 00.00% [390, 391, 392]
🔵 com/starrocks/lake/compaction/CompactionControlScheduler.java 46 65 70.77% [104, 239, 265, 266, 267, 268, 269, 270, 271, 273, 274, 275, 277, 278, 279, 280, 281, 282, 283]
🔵 com/starrocks/catalog/OlapTable.java 10 10 100.00% []
🔵 com/starrocks/server/LocalMetastore.java 3 3 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@gengjun-git gengjun-git gengjun-git approved these changes

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@meegoo meegoo

Labels
3.2 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meegoo @kevincai @wyb @gengjun-git