Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog #45933

Merged
merged 1 commit into from
May 21, 2024

Conversation

starrocks-xupeng
Copy link
Contributor

@starrocks-xupeng starrocks-xupeng commented May 20, 2024

Why I'm doing:

What I'm doing:

do not check whether global state mgr is leader when writes star mgr's journal

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

nshangyiming
nshangyiming previously approved these changes May 20, 2024
nshangyiming
nshangyiming previously approved these changes May 20, 2024
Copy link

sonarcloud bot commented May 20, 2024

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/persist/EditLog.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@nshangyiming nshangyiming merged commit 95b551d into StarRocks:main May 21, 2024
44 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 21, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label May 21, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label May 21, 2024
Copy link
Contributor

mergify bot commented May 21, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 21, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 21, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 21, 2024
…g` (#45933)

Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 95b551d)
mergify bot pushed a commit that referenced this pull request May 21, 2024
…g` (#45933)

Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 95b551d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java
mergify bot pushed a commit that referenced this pull request May 21, 2024
…g` (#45933)

Signed-off-by: starrocks-xupeng <[email protected]>
(cherry picked from commit 95b551d)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java
starrocks-xupeng added a commit to starrocks-xupeng/starrocks that referenced this pull request May 21, 2024
@starrocks-xupeng
Copy link
Contributor Author

starrocks-xupeng commented May 21, 2024

#45968, branch-3.2

@starrocks-xupeng
Copy link
Contributor Author

#45962, branch-3.1

nshangyiming pushed a commit that referenced this pull request May 21, 2024
nshangyiming pushed a commit that referenced this pull request May 21, 2024
wanpengfei-git pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants