-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog
#45933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshangyiming
previously approved these changes
May 20, 2024
nshangyiming
previously approved these changes
May 20, 2024
kevincai
approved these changes
May 20, 2024
Signed-off-by: starrocks-xupeng <[email protected]>
Quality Gate passedIssues Measures |
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
nshangyiming
approved these changes
May 21, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java
Closed
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java
Closed
42 tasks
starrocks-xupeng
added a commit
to starrocks-xupeng/starrocks
that referenced
this pull request
May 21, 2024
…g` (backport StarRocks#45933) Signed-off-by: starrocks-xupeng <[email protected]>
#45968, branch-3.2 |
#45962, branch-3.1 |
nshangyiming
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (backport #45933) (#45968) Signed-off-by: starrocks-xupeng <[email protected]>
nshangyiming
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (backport #45933) (#45962) Signed-off-by: starrocks-xupeng <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
May 21, 2024
…g` (backport #45933) (#45958) Co-authored-by: starrocks-xupeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
do not check whether global state mgr is leader when writes star mgr's journal
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: