[BugFix] Fix arrow parquet exception handling #25621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Letian Jiang <[email protected]>
Signed-off-by: Letian Jiang <[email protected]>
Signed-off-by: Letian Jiang <[email protected]>
Smith-Cruise
approved these changes
Jun 20, 2023
Youngwb
approved these changes
Jun 20, 2023
dirtysalt
approved these changes
Jun 20, 2023
letian-jiang
added a commit
to letian-jiang/starrocks
that referenced
this pull request
Jun 25, 2023
This reverts commit f610fdf.
letian-jiang
added a commit
to letian-jiang/starrocks
that referenced
this pull request
Jun 25, 2023
This reverts commit f610fdf. Signed-off-by: Letian Jiang <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23606, where memory leaks are introduced by
_chunk_writer->release()The modification on Arrow is to make sure
RowGroupSerializer::column_writers_is cleaned up even if exception throws.You may refer apache/arrow#35520 for more details.
What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: