Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/osc #863

Merged
merged 16 commits into from
Sep 6, 2024
Merged

Fix/osc #863

merged 16 commits into from
Sep 6, 2024

Conversation

cremebrule
Copy link
Contributor

No description provided.

@cremebrule cremebrule requested review from cgokmen, ChengshuLi, hang-yin and wensi-ai and removed request for cgokmen August 30, 2024 01:48
wensi-ai
wensi-ai approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@wensi-ai wensi-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ChengshuLi
ChengshuLi approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments! Feel free to merge once those are addressed.

omnigibson/robots/manipulation_robot.py Show resolved Hide resolved
omnigibson/utils/usd_utils.py Show resolved Hide resolved
tests/test_controllers.py Outdated Show resolved Hide resolved
tests/test_controllers.py Outdated Show resolved Hide resolved
tests/test_controllers.py Show resolved Hide resolved
ChengshuLi
ChengshuLi approved these changes Sep 4, 2024
View reviewed changes
omnigibson/controllers/ik_controller.py Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Show resolved Hide resolved
omnigibson/utils/transform_utils.py Show resolved Hide resolved
@cremebrule cremebrule merged commit 0d897a8 into og-develop Sep 6, 2024
1 of 17 checks passed
@cremebrule cremebrule deleted the fix/osc branch September 6, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wensi-ai wensi-ai wensi-ai approved these changes

@ChengshuLi ChengshuLi ChengshuLi approved these changes

@hang-yin hang-yin Awaiting requested review from hang-yin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cremebrule @ChengshuLi @wensi-ai