Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base footprint offset not applied in ControllableObjectViewAPI #857

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix base footprint offset not applied in ControllableObjectViewAPI #857

merged 2 commits into from
Aug 26, 2024

Conversation

cgokmen
Copy link
Contributor

@cgokmen cgokmen commented Aug 24, 2024

No description provided.

@cgokmen cgokmen linked an issue Aug 24, 2024 that may be closed by this pull request
Compute all ControllableObjectViewAPI values with respect to robot's base footprint pose instead of the origin for Tiago etc. #856
Closed
@cgokmen cgokmen marked this pull request as ready for review August 24, 2024 00:44
@cgokmen cgokmen requested a review from ChengshuLi August 24, 2024 01:02
ChengshuLi
ChengshuLi approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge if you have tested this.

@cgokmen cgokmen merged commit 3121e2c into og-develop Aug 26, 2024
14 of 18 checks passed
@cgokmen cgokmen deleted the fix-base-footprint-offset branch August 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengshuLi ChengshuLi ChengshuLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cgokmen @ChengshuLi