Merge pull request #927 from StanfordVL/fix-install

Fix missing rename behavior in old glibc versions

docs/getting_started/installation.md

@@ -78,11 +78,11 @@ There are three ways to setup **`OmniGibson`**, all built upon different ways of
 
         3. Run the installation script to  install Isaac Sim as well as **`OmniGibson`** dataset and assets:
 
-            ```{.shell .annotate} 
-            python -m omnigibson.install # (1)!
+            ```shell
+            python -m omnigibson.install
             ```
 
-            1. You can apply additional flag `--no-install-datasets` to skip dataset install.
+            You can apply additional flag `--no-install-datasets` to skip dataset install.
 
             If this step fails, we recommend considering the [source installation](#__tabbed_1_3) method.
 
@@ -207,11 +207,11 @@ There are three ways to setup **`OmniGibson`**, all built upon different ways of
 
         4. Run the installation script to hook the environment up to Isaac Sim as well as **`OmniGibson`** dataset and assets:
 
-            ```{.shell .annotate} 
-            python -m omnigibson.install --launcher-install # (1)!
+            ```shell
+            python -m omnigibson.install --launcher-install
             ```
 
-            1. You can specify your Isaac Sim install location using the argument `--isaac-sim-path` if it differs from the default. You can also apply additional flag `--no-install-datasets` to skip dataset install.
+            You can specify your Isaac Sim install location using the argument `--isaac-sim-path` if it differs from the default. You can also apply additional flag `--no-install-datasets` to skip dataset install.
 
             !!! note "What does this do?"
 

omnigibson/install.py

@@ -82,8 +82,13 @@ def _rename_if_necessary(filename: Path):
     This is permissible because the manylinux wheels are compatible with older GLIBC versions even though
     the filename suggests not - so we apply this hacky workaround. This allows pip to try to install them.
     """
+    # Rename the file if the system's GLIBC version is older than the one used in the NVIDIA PyPI packages
     if platform.system() == "Linux" and _is_glibc_older():
-        return filename.with_name(filename.name.replace("manylinux_2_34", "manylinux_2_31"))
+        new_filename = filename.with_name(filename.name.replace("manylinux_2_34", "manylinux_2_31"))
+        shutil.move(filename, new_filename)
+        return new_filename
+
+    # If the file is not renamed, return the original filename
     return filename
 
 
@@ -278,7 +283,9 @@ def attempt_pip_install():
 
 @click.command()
 @click.option(
-    "--install-datasets", default=True, help="Install the OmniGibson dataset and assets after installing Isaac Sim"
+    "--install-datasets/--no-install-datasets",
+    default=True,
+    help="Install the OmniGibson dataset and assets after installing Isaac Sim",
 )
 @click.option(
     "--launcher-install/--pip-install",