Fix duplicated delivery of Omron Measurements #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
PSchmiedmayer
approved these changes
Aug 15, 2024
1 task
Supereg
added a commit
to StanfordBDHG/ENGAGE-HF-iOS
that referenced
this pull request
Aug 20, 2024
# Improve Bluetooth and Account interactions ## ♻️ Current situation & Problem The latest SpeziBluetooth and SpeziDevices releases fixed several issues (StanfordSpezi/SpeziDevices#9, StanfordSpezi/SpeziBluetooth#46) including the duplicate delivery of measurements and minor pairing issues. Additionally, this PR upgrades to the upcoming SpeziAccount release that provides several improvements when interacting with Account Services. We updated code to avoid directly interaction with FirebaseAuth. ## ⚙️ Release Notes * Fixed an issue where measurements were delivered twice or not at all. * Fixed an issue where a Weight Scale was considered paired to early. * Improved general structure of the application integrating latest SpeziAccount features. ## 📚 Documentation -- ## ✅ Testing -- ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicated delivery of Omron Measurements
♻️ Current situation & Problem
This PR fixes some minor issues with the current implementation of Omron devices. StanfordSpezi/SpeziBluetooth#46 made two important changes to improve the overall reliability of the implementation. First, it fixes an issue with notify-only characteristics (like weight and blood pressure measurement characteristics) where the
onChangewould not be called. Secondly, while the device is subscribing to characteristic notifications, the state is still set toconnecting, this allows us to properly filter the initial measurement notifications that Omron devices send when subscribing to characteristics. Further, this allowed us to fix an issue where we couldn't properly determine the point in time where a weight scale was fully paired by the user.Additionally this PR adds a small time label for the
MeasurementsRecordedSheetand adds German localization.⚙️ Release Notes
MeasurementsRecordedSheet.📚 Documentation
Added a small documentation article that collects knowledge about Omron devices.
✅ Testing
We used manual testing with real Omron devices to verify the implementation. Some additional unit tests were added to ensure no regression occur.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: