BP7000 and EVOLV Support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Supereg
commented
Jul 17, 2024
Supereg
commented
Jul 17, 2024
Supereg
commented
Jul 17, 2024
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
===========================================
+ Coverage 70.66% 84.42% +13.77%
===========================================
Files 29 55 +26
Lines 1690 2824 +1134
===========================================
+ Hits 1194 2384 +1190
+ Misses 496 440 -56
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This is an amazing addition; thank you for the added support here @Supereg!
Sources/SpeziDevicesUI/SpeziDevicesUI.docc/Resources/DeviceDetails~dark.png
Outdated
Show resolved
Hide resolved
Sources/SpeziDevicesUI/SpeziDevicesUI.docc/Resources/PairedDevices~dark.png
Outdated
Show resolved
Hide resolved
Sources/SpeziOmron/Resources/Media.xcassets/Omron-BP5250.imageset/Omron-BP5250.png.license
Outdated
Show resolved
Hide resolved
Supereg
added a commit
to StanfordBDHG/ENGAGE-HF-iOS
that referenced
this pull request
Jul 18, 2024
# Integrate BP7000 and EVOLV Blood Pressure Cuffs ## ♻️ Current situation & Problem This PR integrates the changes from StanfordSpezi/SpeziDevices#7 adding support for BP7000 and EVOLV blood pressure cuffs. Devices might need to be connected once to refresh their icon assets due to underlying changes in SpeziDevices on how assets are derived from the PairedDeviceInfo storage. ## ⚙️ Release Notes * Integrated BP7000 and EVOLV BPs ## 📚 Documentation -- ## ✅ Testing Manual testing using the BP7000. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP7000 and EVOLV Support
♻️ Current situation & Problem
This PR adds support for Omron BP7000 and Omron EVOLV blood pressure cuffs. The implementation of both devices is still achieved using the
OmronBloodPressureCuffdevice. The device icon can now be supplied dynamically by the device class based on device features. This makes it possible for a device implementation to visually distinguish between multiple different models. Currently, we only support to differentiate between different based on the peripheral name.⚙️ Release Notes
📚 Documentation
Documentation was updated to reflect the changes made by this PR.
✅ Testing
Testing was added to test new components.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: