Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README to include variables for MPI #919

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

rzambre
Copy link

@rzambre rzambre commented Aug 26, 2020

Setting USE_MPI=1 alone does not configure Legion to use the MPI
backend. It must be coupled with REALM_NETWORKS=mpi.

@rzambre
Copy link
Author

rzambre commented Aug 26, 2020

The README currently does not mention the existence of the REALM_NETWORKS variable. That documentation is hidden in the CHANGES.txt file.

@streichler
Copy link
Contributor

I agree that the README should probably talk about MPI network layer, but that's not what USE_MPI=1 does. USE_MPI=1 enables the MPI compatibility logic in Legion and Realm. Is that what you're trying to get, or did you actually want the MPI
network layer in Realm?

@streichler streichler self-assigned this Aug 26, 2020
@rzambre
Copy link
Author

rzambre commented Aug 26, 2020

I see. I want to actually use the MPI backend in Realm.
Is it possible to use the MPI network layer with just REALM_NETWORKS=mpi and without USE_MPI=1 ?

@streichler
Copy link
Contributor

Is it possible to use the MPI network layer with just REALM_NETWORKS=mpi and without USE_MPI=1 ?

Yes, REALM_NETWORKS=mpi should be sufficient on its own.

@rzambre
Copy link
Author

rzambre commented Aug 26, 2020

Got it, I have updated the PR to reflect the availability of the REALM_NETWORKS variable.

@streichler
Copy link
Contributor

Thanks. Rather than taking this little change as is, I'm inclined to use this PR as a forcing function to do a larger update of those docs to include all the other build switches we've been bad at documenting over the years. :)

@rzambre
Copy link
Author

rzambre commented Aug 27, 2020

Sounds great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants