-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwloc-2.0 support #575
Comments
Yes, this is somewhere on our task list. It's not super-high though, as you can almost |
Thanks for the quick reply. I made a small patch to fix one of the two compilation issues.
I wish I knew ;) I'm just the packager here, and I'm only touching legion because I want to update mpich. |
As mentioned in the pull request, I'd like this change to add hwloc-2.x support without losing hwloc-1.x support, so it'll all need to be ifdef-protected. |
Still waiting for update to hwloc-2.6.0 |
If you have any patch please provide it as I could add it to gentoo ebuild |
@scardracs As was suggested a while back, I think the simplest thing to do here is to remove the Legion package's dependence on hwloc entirely. We routinely build without hwloc in our development, so I'm not sure what the issue that @keszybz encountered before was. If you're not sure how to disable use of hwloc in Legion, please point me at your build script and I'll see if I can suggest something. |
Yeah I know how to remove it, the only point is that Gentoo ebuild use +hwloc, which means is forced by default. If you prefer to remove it I can proceed on dropping it on Gentoo side (as I'm working on cleanup/maintain it) |
I'm not that familiar with Gentoo's build system, but having Legion's use of hwloc be disabled by default sounds better to me. |
Short answer: Gentoo uses ebuilds, which use a list of flags (IUSE). On legion there is a IUSE="... +hwloc ..." and that means it is forced by default if not disabled system-wide. I'm gonna drop it this evening. |
Doesn't build with newer versions right now and it looks like (not being an expert in cluster stuff at all, to be fair) hwloc isn't super important here from the upstream comments (there's alternatives available which are used by default). Bug: StanfordLegion/legion#575 Bug: https://bugs.gentoo.org/796128 Signed-off-by: Sam James <[email protected]>
Hi,
mpich 3.3 now requires hwloc>=2.0. It would be great if legion could be updated too.
This was already signalled in #479 in February :(
The text was updated successfully, but these errors were encountered: