Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tvOS, visionOS and macOS platform examples #17

Merged
merged 10 commits into from
Apr 14, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 2, 2024

Support tvOS, visionOS and macOS platform examples

♻️ Current situation & Problem

This PR adds tvOS, visionOS and macOS to the CI setup and project configuration to demonstrate a holistic setup.

⚙️ Release Notes

  • Added tvOS, visionOS and macOS platform.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg
Copy link
Member Author

Supereg commented Feb 21, 2024

Not sure why the visionOS UI tests are not running here. The log doesn't really give a clue.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding all the additional support, amazing!

@Supereg
Copy link
Member Author

Supereg commented Feb 24, 2024

Have we ever managed to run visionOS UI tests on GitHub Mac runners? Seems like that is an issue here(?).

@PSchmiedmayer
Copy link
Member

@Supereg I think the issue we are encountering is related to this one: actions/runner-images#8144 (comment).

I remember that I once moved some builds to our hosted runners because the GitHub Runner performance was so slow.

Might be worth to move all of them to GitHub runners now that the macOS 14 runners are all ARM runners.

Regarding visionOS: If actions/runner-images#8144 (comment) indeed solves our problem we might want to add an additional "Setup Task" script argument to our XcodeBuild Reusable Workflow that could perform stuff like this (or any other escape hatches) before running any build? Or we just put visionOS as a custom command and run xcodebuild ourselves ...

@PSchmiedmayer
Copy link
Member

This might be related to the issue we are having here: actions/runner-images#9511

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb4f62c) to head (b809cfa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            4         4           
=========================================
  Hits             4         4           
Files Coverage Δ
Sources/TemplatePackage/TemplatePackage.swift 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4f62c...b809cfa. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 05954d7 into main Apr 14, 2024
17 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/platform-update branch April 14, 2024 22:54
PSchmiedmayer added a commit that referenced this pull request Jun 28, 2024
# Test GitHub Action Runners with Xcode 15.4

## ♻️ Current situation & Problem
- We currently rely on our own runners as shown in #17 and had build
errors as also documented in
actions/runner-images#9511 (comment)

## ⚙️ Release Notes 
- Switch to GitHub-hosted runners and explore the situation after some
Xcode updates.

### Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants