Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unknown Fields #78

Merged
merged 13 commits into from
Aug 26, 2024
Merged

Fix Unknown Fields #78

merged 13 commits into from
Aug 26, 2024

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Aug 23, 2024

Fix Unknown Fields

♻️ Current situation & Problem

  • The viewer crashes if there is no heart rate or other information available for an ECG.

⚙️ Release Notes

  • Fix Unknown Fields

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Aug 23, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (96136ad) to head (8e2d53d).
Report is 1 commits behind head on main.

Files Patch % Lines
PAWS/ECGRecordings/ECGModule.swift 93.34% 2 Missing ⚠️
PAWS/ECGRecordings/ECGRecording.swift 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   74.28%   73.23%   -1.05%     
==========================================
  Files          39       39              
  Lines        1415     1434      +19     
==========================================
- Hits         1051     1050       -1     
- Misses        364      384      +20     
Files Coverage Δ
PAWS/PAWSStandard.swift 64.78% <ø> (ø)
PAWS/Study Information/EnrollmentGroup.swift 97.06% <ø> (ø)
PAWS/ECGRecordings/ECGRecording.swift 97.73% <90.00%> (ø)
PAWS/ECGRecordings/ECGModule.swift 68.97% <93.34%> (-7.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96136ad...8e2d53d. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 56c6521 into main Aug 26, 2024
12 of 13 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fix/viewer branch August 26, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant