Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Icons and Loading of values #6

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Conversation

PSchmiedmayer
Copy link
Member

Name of the PR

♻️ Current situation & Problem

Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR

💡 Proposed solution

Describe the solution and how this affects the project and internal structure

⚙️ Release Notes

Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.

➕ Additional Information

Provide some additional information if possible

Related PRs

Reference the related PRs

Testing

Are there tests included? If yes, which situations are tested, and which corner cases are missing?

Reviewer Nudging

Where should the reviewer start? Where is a good entry point?

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #6 (784a74e) into main (742aad2) will increase coverage by 0.14%.
The diff coverage is 0.00%.

❗ Current head 784a74e differs from pull request most recent head 90d6e99. Consider uploading reports for the commit 90d6e99 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   24.33%   24.46%   +0.14%     
==========================================
  Files          25       24       -1     
  Lines         892      879      -13     
==========================================
- Hits          217      215       -2     
+ Misses        675      664      -11     
Impacted Files Coverage Δ
TemplateApplication/DocumentScanner.swift 0.00% <0.00%> (ø)
TemplateApplication/ProfileView.swift 1.67% <0.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520ed72...90d6e99. Read the comment docs.

@PSchmiedmayer PSchmiedmayer marked this pull request as ready for review March 24, 2023 00:19
@PSchmiedmayer PSchmiedmayer merged commit 01ea6fe into main Mar 24, 2023
@PSchmiedmayer PSchmiedmayer deleted the feature/documentScanning branch March 24, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant