Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NCI Trial API type error, update used GPT models, fix warnings and deprecations, Swift 6 language mode concurrency compatibility #28

Closed

Conversation

philippzagar
Copy link
Collaborator

Fix NCI Trial API type error, update used GPT models, fix warnings and deprecations, Swift 6 language mode concurrency compatibility

♻️ Current situation & Problem

The current state of the application requires a bit of maintenance to keep up with Swift evolution as well as the rest of the Spezi ecosystem. Outdated OpenAI GPT models are used. OpenAPI generated NCI Trial API contains a type error for a property of a response, leading to possible decoding errors

⚙️ Release Notes

  • Fix NCI Trial API type error
  • Update used GPT models
  • Fix warnings and deprecations
  • Swift 6 language mode concurrency compatibility

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

…d deprecations, Swift 6 language mode concurrency compatibility
@philippzagar
Copy link
Collaborator Author

@PSchmiedmayer I had to create a fork of the repo as I apparently don't have write access on the repo.
Also, sadly the CodeCov upload fails, see the build: https://github.com/StanfordBDHG/OwnYourData/actions/runs/11775218427/job/32795500982?pr=28

@philippzagar philippzagar self-assigned this Nov 11, 2024
@philippzagar philippzagar added the enhancement New feature or request label Nov 11, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @philippzagar!

The Codecov token is an issue with CodeCov and forks; they hit their usage limit and don't really support forks at this point. Moving this branch to the repo should give you access to the token and therefore allow you to upload reports.

OwnYourData/Home.swift Show resolved Hide resolved
@philippzagar
Copy link
Collaborator Author

Moved from fork to #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants