Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Access #20

Merged
merged 11 commits into from
May 14, 2024
Merged

Location Access #20

merged 11 commits into from
May 14, 2024

Conversation

PSchmiedmayer
Copy link
Member

Location Access

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 1.20482% with 164 lines in your changes are missing coverage. Please review.

Project coverage is 20.42%. Comparing base (3165d7f) to head (1586e7e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   22.33%   20.42%   -1.90%     
==========================================
  Files          47       49       +2     
  Lines        1438     1582     +144     
==========================================
+ Hits          321      323       +2     
- Misses       1117     1259     +142     
Files Coverage Δ
OwnYourData/OwnYourDataDelegate.swift 97.57% <100.00%> (+0.07%) ⬆️
OwnYourData/ClinicalTrials/TrialView.swift 0.00% <0.00%> (ø)
OwnYourData/Onboarding/LocationPermissions.swift 0.00% <0.00%> (ø)
...wnYourData/ClinicalTrials/ClinicalTrialsView.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3165d7f...1586e7e. Read the comment docs.

Copy link
Member Author

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gracehp1 Thank you for the PR and for looking at the location access! Great to see the progress and incorporating this in the existing app.

I took a look at some of the elements and issues you pointed out in Slack and provided some hints and suggestions on how to incorporate this in the app in the detailed review comments.

SpeziLocation is not fully ready to be released, but it might save you a good amount of headache for this part of the app. You should be able to use the branch name (main) or, ideally, the commit hash of the latest commit to add it to this project. This documentation might be helpful: https://developer.apple.com/documentation/xcode/adding-package-dependencies-to-your-app.

OwnYourData/ClinicalTrials/ClinicalTrialsView.swift Outdated Show resolved Hide resolved
OwnYourData/ClinicalTrials/ClinicalTrialsView.swift Outdated Show resolved Hide resolved
OwnYourData/ClinicalTrials/ClinicalTrialsView.swift Outdated Show resolved Hide resolved
OwnYourData/ClinicalTrials/ClinicalTrialsView.swift Outdated Show resolved Hide resolved
OwnYourData/ClinicalTrials/ClinicalTrialsView.swift Outdated Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer marked this pull request as ready for review May 11, 2024 05:01
@PSchmiedmayer PSchmiedmayer merged commit 24a3063 into main May 14, 2024
4 checks passed
@PSchmiedmayer PSchmiedmayer deleted the graceDev branch May 14, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants