Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Application, Improve Performance, and Fix Logout Logic #10

Merged
merged 3 commits into from
Mar 25, 2023

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Mar 24, 2023

Restructure Application, Improve Performance, and Fix Logout Logic

💡 Proposed solution

  • Restructures the Application to use reusable views
  • Improves the performance to display user information
  • Fixes the logout logic
  • Support Dark Mode

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #10 (20f9d56) into main (f5d6182) will decrease coverage by 2.03%.
The diff coverage is 30.63%.

❗ Current head 20f9d56 differs from pull request most recent head 504f575. Consider uploading reports for the commit 504f575 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   26.64%   24.61%   -2.03%     
==========================================
  Files          35       39       +4     
  Lines        1344     1069     -275     
==========================================
- Hits          358      263      -95     
+ Misses        986      806     -180     
Impacted Files Coverage Δ
...pplication/ClinicalTrials/ClinicalTrialsView.swift 0.00% <ø> (ø)
TemplateApplication/ClinicalTrials/WebView.swift 0.00% <0.00%> (ø)
...emplateApplication/Documents/DocumentGallery.swift 2.95% <0.00%> (ø)
...emplateApplication/Documents/DocumentScanner.swift 0.00% <ø> (ø)
TemplateApplication/Instructions/HowItWorks.swift 0.00% <0.00%> (ø)
...emplateApplication/Instructions/Instructions.swift 0.00% <0.00%> (ø)
...ateApplication/Instructions/InstructionsStep.swift 0.00% <0.00%> (ø)
...eApplication/Instructions/OpenAppleHealthApp.swift 0.00% <0.00%> (ø)
...ication/Onboarding/AccountSetup/AccountSetup.swift 0.00% <0.00%> (ø)
TemplateApplication/Onboarding/Consent.swift 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d6182...504f575. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 25e5b6d into main Mar 25, 2023
@PSchmiedmayer PSchmiedmayer deleted the feature/smallUIImprovements branch March 25, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant