Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NotFound handling #91

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

Improve NotFound handling

♻️ Current situation & Problem

404 errors uses basic tanstack router not found.

⚙️ Release Notes

  • Improve NotFound handling

image

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 0.91%. Comparing base (c835211) to head (fcfb6c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
routes/~_dashboard/users/$id.tsx 0.00% 12 Missing ⚠️
components/NotFound/NotFound.tsx 0.00% 10 Missing and 1 partial ⚠️
main.tsx 0.00% 11 Missing ⚠️
modules/user/queries.tsx 0.00% 10 Missing ⚠️
routes/~_dashboard/patients/$id/~index.tsx 0.00% 7 Missing ⚠️
components/NotFound/index.tsx 0.00% 1 Missing and 1 partial ⚠️
routes/~_dashboard/~patients/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #91      +/-   ##
========================================
- Coverage   0.92%   0.91%   -0.00%     
========================================
  Files         71      73       +2     
  Lines       3602    3637      +35     
  Branches      80      82       +2     
========================================
  Hits          33      33              
- Misses      3502    3535      +33     
- Partials      67      69       +2     
Files with missing lines Coverage Δ
routes/~_dashboard/~patients/utils.ts 0.00% <0.00%> (ø)
components/NotFound/index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/patients/$id/~index.tsx 0.00% <0.00%> (ø)
modules/user/queries.tsx 0.00% <0.00%> (ø)
components/NotFound/NotFound.tsx 0.00% <0.00%> (ø)
main.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/users/$id.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4707881...fcfb6c9. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski merged commit 41ceb1d into main Nov 11, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/add-404-not-found-handler branch November 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant