Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit XCFramework via PAT #42

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

philippzagar
Copy link
Contributor

@philippzagar philippzagar commented Nov 10, 2023

Commit XCFramework via PAT

♻️ Current situation & Problem

At the moment, the xcframework.yml reusable GitHub Action commits the created XCFramework file to a respective branch with the regular GitHub Access Token that is passed to every action. However, if the respective branch has some branch protections (e.g. on the main branch), the default access rights of the token won't be sufficient.

⚙️ Release Notes

  • XCFramework action now takes a PAT and an author name/email that are used to commit the created XCFramework file to the respective branch.

📚 Documentation

Included in the workflow files

✅ Testing

Manually tested

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar
Copy link
Contributor Author

@PSchmiedmayer First release of XCFramework done within the llama.cpp repo by @PaulsAutomationBot: StanfordBDHG/llama.cpp#3

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @philippzagar! 🚀

README.md Show resolved Hide resolved
@philippzagar
Copy link
Contributor Author

@PSchmiedmayer Second release done here: StanfordBDHG/ResearchKit#11

@philippzagar philippzagar merged commit 06a0bad into main Nov 10, 2023
2 checks passed
@philippzagar philippzagar deleted the feat/commit-xcframework-via-optional-pat branch November 10, 2023 23:06
@philippzagar philippzagar self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants