Fix xcodebuild-or-fastlane when not supplying checkout_token #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix xcodebuild-or-fastlane when not supplying checkout_token
♻️ Current situation & Problem
Recent PR #29 added the functionality to supply a PAT for checkout. This functionality was tested wrongfully (oversight where one confused the successful xcodebuild-or-fastlane of
StanfordSpezi/.githubwith this repo).💡 Proposed solution
This PR addresses the issue when not supplying a
checkout_tokenby specifying the defaultgitHub.token. The checkout action failed to do so when supplying an empty token.⚙️ Release Notes
xcodebuild-or-fastlaneaction when not supplying acheckout_token.➕ Additional Information
Related PRs
Originally implemented in #29.
Testing
Functionality was verified by this CI run. The CodeQL step runs the action without supplying a
checkout_token.This time it was taken care of the CodeQL action runs the same
xcodebuild-or-fastlaneworkflow from this repository (see StanfordBDHG/NAMS@f98bcff).Reviewer Nudging
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: