Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnthosL4LB resource map #246

Merged
merged 7 commits into from
Jul 23, 2020
Merged

Conversation

courageJ
Copy link
Contributor

No description provided.

retrieval/resource_map.go Outdated Show resolved Hide resolved
retrieval/resource_map.go Outdated Show resolved Hide resolved
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be better if @StevenYCChou took a look as well.
@qingling128 for visibility.

@StevenYCChou
Copy link
Contributor

LGTM. The build fails due to coverall, and I think it's a known issue when the branch is not from this repo. I am going to merge this PR now.

@StevenYCChou StevenYCChou merged commit adcf43c into Stackdriver:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants