Migrate to kubeconform for k8s linting, as kubeval is now deprecated #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
jk464
force-pushed
the
feature/kubeconform
branch
from
6488553
to
e108010
Compare
jk464
force-pushed
the
feature/kubeconform
branch
from
e108010
to
5de9772
Compare
cognifloyd
approved these changes
May 21, 2024
|
LGTM. Would you please deal with the changelog conflict? Then it should auto merge. |
auto-merge was automatically disabled
May 21, 2024 09:35
Head branch was pushed to by a user without write access
jk464
force-pushed
the
feature/kubeconform
branch
2 times, most recently
from
c88a86b
to
ce56060
Compare
jk464
force-pushed
the
feature/kubeconform
branch
from
ce56060
to
5a27fd5
Compare
|
@cognifloyd you'll need to merge manually - sadly auto-merge was disabled when I pushed to the branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/instrumenta/kubeval/blob/master/README.md -
kubevalis deprecated, and the recommended replacement is kubeconform.This PR replaces our use of
kubevalin the CIk8s-lintstep withkubeconform.Implementation is done using the
helm pluginprovided here https://github.com/jtyr/kubeconform-helm.Justification for moving, aside from the deprecation, is the likes of #401 - where we could potentially add the use of 3rd party
k8smodules(?), likecert-manager.kubeconformmakes it very easy to validate these 3rd party additions by simply passinghttps://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.jsonas a schema location