Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add donate button to st2web UI header #812

Closed
wants to merge 2 commits into from
Closed

Add donate button to st2web UI header #812

wants to merge 2 commits into from

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Oct 13, 2020 •
edited
Loading

Closes #811

Packages installed from this PR CircleCI build shows the following "Donate" button linking to the https://stackstorm.com/donate/

@arm4b arm4b added the feature label Oct 13, 2020
@arm4b arm4b added this to the 3.3.0 milestone Oct 13, 2020
@arm4b arm4b marked this pull request as draft October 13, 2020 15:17
@m4dcoder m4dcoder marked this pull request as ready for review October 13, 2020 16:29
m4dcoder
m4dcoder requested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@m4dcoder m4dcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against adding the donate button here. This is distasteful. A little bit desperate.

@arm4b
Copy link
Member Author

arm4b commented Oct 13, 2020 •
edited
Loading

OK, I'm adding this item up to @StackStorm/tsc discussion.

As we have Donate button on StackStorm.com, Github, I don't see how it's distasteful to have it on st2web too.
I never thought it would be something of disagreement as we're observing a problem supporting the project and covering its expenses (StackStorm/community#36).

I'd better have it on st2web and allow broader Community supporting the StackStorm infra expenses, rather then see a day when users won't be able to install the tool as some system behind st2 infra goes offline as unpaid due.

@arm4b arm4b modified the milestones: 3.3.0, 3.4.0 Oct 13, 2020
@arm4b arm4b requested a review from a team October 13, 2020 18:36
@arm4b arm4b mentioned this pull request Oct 28, 2020
Closed
@arm4b arm4b mentioned this pull request Nov 27, 2020
Closed
@amanda11 amanda11 mentioned this pull request Dec 29, 2020
Closed
@arm4b arm4b removed this from the 3.4.0 milestone Jan 13, 2021
@arm4b arm4b added the wontfix label Jan 18, 2021
@cognifloyd
Copy link
Member

I'm closing this as it is marked wontfix

@cognifloyd cognifloyd closed this Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4dcoder m4dcoder m4dcoder requested changes

Assignees
No one assigned
Labels
feature wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebUI: Add Donate button
3 participants
@arm4b @cognifloyd @m4dcoder