Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files for building from Rocky8 #171

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Add files for building from Rocky8 #171

merged 4 commits into from
Jan 22, 2022

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jan 14, 2022 •
edited
Loading

Move building of st2chatops for el8 from centos8 to rocky8.

Part of StackStorm/community#88

@amanda11 amanda11 added the OS support Support/issues/PRs on a specific OS label Jan 14, 2022
@amanda11 amanda11 changed the title [WIP] Add files for building from Rocky8 Add files for building from Rocky8 Jan 14, 2022
@amanda11
Copy link
Contributor Author

Ready for review, but would like to hold out on merge until the st2-packages corresponding PR is ready...

@amanda11 amanda11 added the RFR label Jan 14, 2022
@amanda11 amanda11 mentioned this pull request Jan 21, 2022
Closed
16 tasks
arm4b
arm4b reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering rockylinux is replacing centos8 for the build, I think there's also a need to remove the inactive centos8 Dockerfiles to avoid confusion in the future

https://github.com/StackStorm/st2chatops/tree/master/packagingenv
https://github.com/StackStorm/st2chatops/tree/master/testingenv

@amanda11
Copy link
Contributor Author

Considering rockylinux is replacing centos8 for the build, I think there's also a need to remove the inactive centos8 Dockerfiles to avoid confusion in the future

https://github.com/StackStorm/st2chatops/tree/master/packagingenv https://github.com/StackStorm/st2chatops/tree/master/testingenv

Removed them (unfortunate side affect git diff reports them as a move from centos8 to rockylinux8 - but was an add and a delete...)

arm4b
arm4b approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

@cognifloyd
Copy link
Member

cognifloyd commented Jan 22, 2022 •
edited
Loading

Ready for review, but would like to hold out on merge until the st2-packages corresponding PR is ready...

Both of the other PRs have been merged. Merging.

@cognifloyd cognifloyd merged commit bb51c65 into master Jan 22, 2022
@cognifloyd cognifloyd deleted the rocky branch January 22, 2022 04:52
@amanda11
Copy link
Contributor Author

@cognifloyd Thanks for merge - wasn't online when the changes got approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
OS support Support/issues/PRs on a specific OS RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanda11 @cognifloyd @arm4b