Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pants: add dependencies to the st2common python_distribution #5925

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Pants: add dependencies to the st2common python_distribution #5925

merged 8 commits into from
Mar 10, 2023

Commits on Mar 10, 2023

  1. fix: packaging migration scripts 

    Running `./pants package ::` results in the following error. We included
the v3.5 migration script in `setup.py` and in the `pants_distribution`.
But, that script does not end in `.py`, so the `python_sources` target
did not "own" it. In order to correct this, we explicitly include the
extension-less binaries.

> ValueError: The explicit dependency
> `st2common/bin/migrations/v3.5/st2-migrate-db-dict-field-values` of
> the target at `st2common:st2common` does not provide enough address
> parameters to identify which parametrization of the dependency target
> should be used.
> Target `st2common/bin/migrations/v3.5:v3.5` can be addressed as:
>   * st2common/bin/migrations/v3.5:v3.5
>   * st2common/bin/migrations/v3.5/__init__.py
>   * st2common/bin/migrations/v3.5/st2_migrate_db_dict_field_values.py

In fixing this, I also noticed that we did not include the v3.8
migration script, so I marked that executable and included it as well.
    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f2b8644 View commit details
    Browse the repository at this point in the history

  2. chore: add explicit deps for shell scripts in st2common/bin

    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c10ca30 View commit details
    Browse the repository at this point in the history

  3. add note about commands to use when searching for missing deps

    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3913bde View commit details
    Browse the repository at this point in the history

  4. chore: note known dead code in st2common/BUILD 

    This should probably be deleted. But for now, we just leave a note about why
it is not included in the st2common python_distribution.
    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7fbfa5f View commit details
    Browse the repository at this point in the history

  5. Define API dependencies on code that should be in st2common wheel 

    Since this code is not imported by one of our scripts or entry points,
we need to add an explicit dependency. This starts with several things
that form part of the official "API" of the st2common library.
    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ae69358 View commit details
    Browse the repository at this point in the history

  6. bugfix: remove bad arg in st2common/bin/migrations/v3.8/st2-drop-st2e… 

    …xporter-marker-collections
    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5703195 View commit details
    Browse the repository at this point in the history

  7. fix: drop unused imports

    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    40db4a1 View commit details
    Browse the repository at this point in the history

  8. update changelog entry

    @cognifloyd
    cognifloyd committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    2fa16d8 View commit details
    Browse the repository at this point in the history