Upgrade pants from 2.14 to 2.15 #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
winem,
arm4b,
nzlosh,
rush-skills,
amanda11 and
a team
pull-request-size
bot
added
the
size/XXL
This comment was marked as outdated.
This comment was marked as outdated.
cognifloyd
force-pushed
the
pants-upgrade-2.15
branch
11 times, most recently
from
e1a2ed8
to
2ad24d3
Compare
cognifloyd
force-pushed
the
pants-upgrade-2.15
branch
2 times, most recently
from
f05a11c
to
2f5b886
Compare
The Fmt/Lint plugin API changed in pants 2.15 It now requires a Subsystem with a SkipOption. I took advantage of this to consolidate the constants and all the address and pex request definitions in the Subsystem subclass. It now requires 2 rules instead of 1: to partition, then fmt/lint. That means the structure of the rule requests had to change slightly. The tests also had to account for the modified rules.
The Fmt/Lint plugin API changed in pants 2.15 It now requires a Subsystem with a SkipOption. I took advantage of this to consolidate the constants and all the address and pex request definitions in the Subsystem subclass. It now requires 2 rules instead of 1: to partition, then fmt/lint. That means the structure of the rule requests had to change slightly. The tests also had to account for the modified rules.
The Fmt/Lint plugin API changed in pants 2.15 It now requires a Subsystem with a SkipOption. I took advantage of this to consolidate the constants and all the address and pex request definitions in the Subsystem subclass. It now requires 2 rules instead of 1: to partition, then fmt/lint. That means the structure of the rule requests had to change slightly. The tests also had to account for the modified rules.
cognifloyd
force-pushed
the
pants-upgrade-2.15
branch
from
2f5b886
to
d7232b8
Compare
cognifloyd
force-pushed
the
pants-upgrade-2.15
branch
from
d7232b8
to
ea02b9d
Compare
amanda11
reviewed
Feb 27, 2023
|
@amanda11. I adjusted the comments to hopefully clarify things. Look in the subsystem.py files to see where the script defintions moved. |
amanda11
approved these changes
Feb 27, 2023
arm4b
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This updates to pants to
2.15.0which requires:fmtandlintplugins in pants-plugins.The required plugin updates are described in the pants Plugin upgrade guide.
Notes about updating to pants 2.15.0
Here are some links to learn more about pants v2.15:
NB: We must do updates 1 minor version of pants at a time so that pants
update-build-filesgoal can handle any required updates before continuing. We want to go to 2.16, but the 2.15 update was significant enough that it deserves its own PR before jumping to 2.16.Aside: As soon as the
pants 2.16.0rc0comes out, I want to switch to that one as we need some of the features in 2.16 like the newstevedorebackend, and improvements to exporting virtualenvs based on lockfiles. That does not look like it will require extensive plugin upgrades like the 2.15 upgrade does.The Fmt/Lint plugin API changed in pants 2.15
It now requires a Subsystem with a SkipOption. I took advantage of this to consolidate the constants and all the address and pex request definitions in the Subsystem subclass.
It now requires 2 rules instead of 1: to partition, then fmt/lint. That means the structure of the rule requests had to change slightly. The tests also had to account for the modified rules.
Refer to the Plugin upgrade guide for more details.