Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump black to v22.3.0 and update format #5606

Merged
merged 5 commits into from
Apr 2, 2022
Merged

Bump black to v22.3.0 and update format #5606

merged 5 commits into from
Apr 2, 2022

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Apr 2, 2022

black v22.3.0 fixes an incompatibility with click, which is a transitive dep.
see: psf/black#2964

I've had to update other projects recently for the same issue.

I just saw an error in CI that hit this issue, so let's update before anything else bites us.
see: https://github.com/StackStorm/st2/runs/5796530459?check_suite_focus=true

Also includes a minor fixture update (test_content_pack submodule) because I'm tired of Make complaining. There is no functional difference with the update. The test pack has newer commits because of CI updates on the exchange.

@cognifloyd cognifloyd added this to the 3.7.0 milestone Apr 2, 2022
@cognifloyd cognifloyd self-assigned this Apr 2, 2022
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Apr 2, 2022
The fixture only had CI-related changes, nothing of import.
This just keeps make from constantly trying to update it.
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Apr 2, 2022
Copy link
Contributor

@nzlosh nzlosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cognifloyd cognifloyd merged commit b384afe into master Apr 2, 2022
@cognifloyd cognifloyd deleted the black-22-3-0 branch April 2, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependency size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants