-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin networkx to versions lower than 2.6 which doesn't support Python 3.6 #5376
Conversation
Do we need a Changelog for this? Per https://app.circleci.com/pipelines/github/StackStorm/st2/2203/workflows/a41eaa05-3034-4f36-aa22-372ca0f83aea/jobs/13713 Ubuntu Bionic build is failing on:
Or do you think it'll get fixed by the Orquesta StackStorm/orquesta#242 change? |
I can confirm that the Orquesta-PR should fix the failure on U18. networkx does no longer require "decorator" as stated in the release notes here: https://github.com/networkx/networkx/blob/v2.6/doc/release/release_2.6.rst I also checked the code of networkx 2.6 and can confirm that the dependency was dropped (as expected). And I would vote for a changelog record for st2 so that users know or at least can see that we pin networkx to 2.6 |
Remove myself from senior maintainers
Update Makefile
Add reload systemd to run unit generator for st2ctl
Here's the issue with decorator: |
Yeah! All CI is passing now |
Hmm. Maybe we should merge StackStorm/orquesta#242 and update the orquesta commit in this PR as well. edit: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the help @cognifloyd and @winem |
Just seen on CentOS7/8 during package build process:
This PR pins networkx to versions lower than 2.6