Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin networkx to versions lower than 2.6 which doesn't support Python 3.6 #5376

Merged
merged 23 commits into from
Oct 2, 2021

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Oct 1, 2021

Just seen on CentOS7/8 during package build process:

[wheelhouse: st2] [13:58:59]      Processing /tmp/wheelhouse/networkx-2.6.3-py3-none-any.whl
[wheelhouse: st2] [13:58:59]        File was already downloaded /tmp/wheelhouse/networkx-2.6.3-py3-none-any.whl
[wheelhouse: st2] [13:58:59]      ERROR: Package 'networkx' requires a different Python: 3.6.8 not in '>=3.7'
[wheelhouse: st2] [13:58:59]      WARNING: You are using pip version 20.3.3; however, version 21.2.4 is available.
[wheelhouse: st2] [13:58:59]      You should consider upgrading via the '/usr/bin/python3 -m pip install --upgrade pip' command.
[wheelhouse: st2] [13:58:59]      make: *** [.stamp-wheelhouse] Error 1
ERROR: 1

Exited with code exit status 1

This PR pins networkx to versions lower than 2.6

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Oct 1, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2021

CLA assistant check
All committers have signed the CLA.

@arm4b arm4b added this to the 3.6.0 milestone Oct 1, 2021
@arm4b
Copy link
Member

arm4b commented Oct 1, 2021

Do we need a Changelog for this?

Per https://app.circleci.com/pipelines/github/StackStorm/st2/2203/workflows/a41eaa05-3034-4f36-aa22-372ca0f83aea/jobs/13713 Ubuntu Bionic build is failing on:

[package: st2] [15:15:58]      ERROR: Cannot install -r ./requirements.txt (line 30) and -r ./requirements.txt (line 36) because these package versions have conflicting dependencies.
[package: st2] [15:15:58]      The conflict is caused by:
[package: st2] [15:15:58]          jsonpath-rw 1.4.0 depends on decorator
[package: st2] [15:15:58]          networkx 2.5.1 depends on decorator<5 and >=4.3

Or do you think it'll get fixed by the Orquesta StackStorm/orquesta#242 change?

@winem
Copy link
Contributor

winem commented Oct 1, 2021

I can confirm that the Orquesta-PR should fix the failure on U18.

networkx does no longer require "decorator" as stated in the release notes here: https://github.com/networkx/networkx/blob/v2.6/doc/release/release_2.6.rst

I also checked the code of networkx 2.6 and can confirm that the dependency was dropped (as expected).

And I would vote for a changelog record for st2 so that users know or at least can see that we pin networkx to 2.6

@nzlosh nzlosh requested review from a team as code owners October 2, 2021 12:26
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Oct 2, 2021
@cognifloyd
Copy link
Member

Here's the issue with decorator:
networkx depends on decorator<5, so it should resolve decorator-4.4.2. On python3.6, it does just that. On python3.8, however, the wheel does not say that it supports python3.8. That was added 1 commit after the wheel for 4.4.2 was uploaded to pypi. In other words, the commit tagged 4.4.2 on github is one commit past what was used to build the wheel on pypi.
Let's try pinning decorator, a transient dep, to see if that helps pip figure out what to do.

@cognifloyd
Copy link
Member

Yeah! All CI is passing now

@cognifloyd
Copy link
Member

cognifloyd commented Oct 2, 2021

Hmm. Maybe we should merge StackStorm/orquesta#242 and update the orquesta commit in this PR as well. edit: done

Copy link
Contributor

@winem winem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cognifloyd cognifloyd removed the request for review from a team October 2, 2021 20:06
@winem winem merged commit 7a6f7a5 into StackStorm:master Oct 2, 2021
@nzlosh nzlosh deleted the networkx_pin branch October 3, 2021 22:16
@nzlosh
Copy link
Contributor Author

nzlosh commented Oct 3, 2021

Thanks for the help @cognifloyd and @winem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants