Use Jinja sandboxed environment #5359
Merged
+26
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
nzlosh
approved these changes
Sep 16, 2021
m4dcoder
requested changes
Sep 16, 2021
There was a problem hiding this comment.
- Do we need to update Jinja >= 2.11 in requirements?
- Please update orquesta version in requirements to use the commit with the similar fix (after Use Jinja sandboxed environment orquesta#240 is merged).
- Please add a changelog entry.
- Please update description of this PR on why this fix is needed.
@m4dcoder I've addressed your requirements, Jinja is already at 2.11 in the requirements on ST2 requirements. |
pull-request-size
bot
added
size/S
The networkx library has changed some interfaces in v2.x. The node attribute is no longer a member of DiGraph therefore use nodes attribute instead.
pull-request-size
bot
added
size/M
|
|
m4dcoder
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Jinja sandboxed environment, so that any templates that attempt to access insecure code will be rejected.