Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin PyOpenSSL<20 and prettytable<2 due to python2.7 conflicts #5131

Closed
wants to merge 3 commits into from
Closed

Pin PyOpenSSL<20 and prettytable<2 due to python2.7 conflicts #5131

wants to merge 3 commits into from

Commits on Jan 29, 2021

  1. Pin PyOpenSSL<20 to avoid cryptography==2.8 conflict 

    In order to install st2 v3.3 requirements on py2.7, we need to pin
PyOpenSSL<20.

We require requests==2.23.0 which needs pyOpenSSL >= 0.14.
https://github.com/psf/requests/blob/v2.23.0/setup.py#L105

We also pin cryptography==2.8, but pyOpenSSL==20.0.0 was
released Nov 27, 2020 and that requires cryptography>=3.2.
https://github.com/pyca/pyopenssl/blob/20.0.0/setup.py#L98
    @cognifloyd
    cognifloyd committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    214bdb8 View commit details
    Browse the repository at this point in the history

  2. Pin prettytable<2.0 

    prettytable 2.0 was released in November 2020. It does not support
python 2.7. Pin it for the 3.3 branch.
    @cognifloyd
    cognifloyd committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    2f2f2a8 View commit details
    Browse the repository at this point in the history

  3. use v3.3 branch for circleci packaging workflow

    @cognifloyd
    cognifloyd committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    97a0315 View commit details
    Browse the repository at this point in the history