Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve python2 pack warning when running on Python 3 environment #5099

Merged
merged 10 commits into from
Dec 17, 2020

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Dec 3, 2020

Update the python2 pack warning when on a python3 environment, to indicate python2 pack is now removed.

Part of StackStorm/community#54

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Dec 3, 2020
@amanda11
Copy link
Contributor Author

amanda11 commented Dec 3, 2020

I've kept in the old warning for when running on a py2 environment, in case the U16 changes don't get in.

@amanda11 amanda11 added this to the 3.4.0 milestone Dec 3, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Left one minor comment to consider. We'll also need a Changelog for this PR, as usual.

@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Dec 8, 2020
@amanda11 amanda11 merged commit 746ae50 into master Dec 17, 2020
@amanda11 amanda11 deleted the py2_warn_change branch December 17, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants