Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly serialize array in parameters #4872

Closed
wants to merge 11 commits into from

Conversation

blag
Copy link
Contributor

@blag blag commented Feb 22, 2020

H/T @winem.

Closes #4804.
Closes #4861 (via merge).

@blag blag added the bug label Feb 22, 2020
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 22, 2020
@blag blag added this to the 3.2.0 milestone Feb 22, 2020
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR just add the Changelog on top of #4804?

Looks like @winem is pretty active in our Community to be able to add the Changelog record himself.

@blag
Copy link
Contributor Author

blag commented Feb 25, 2020

Yep. I was gonna merge it in early, but he updated his PR, so it's all good. Closing.

@blag blag closed this Feb 25, 2020
@blag blag deleted the properly-serialize-array-in-parameters branch February 25, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell script action not serializing array properly.
4 participants