Fix expression function to_yaml_string to handle mongodb base types #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the filter to_yaml_string used in YAQL/Jinja expressions to be able to handle mongodb base types such as BaseDict and BaseList. The filter will call a helper function to recursively convert BaseDict and BaseList to python dict and list respectively.
jinpingh
reviewed
Jun 24, 2019
Use if-elif instead of multiple if statements to check types when converting from MongoDB BaseDict and BaseList to python dict and list types. Once the value is converted, use another if-elif block to recursively evaluate and convert the values of dict and list.
jinpingh
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the filter to_yaml_string used in YAQL/Jinja expressions to be able to handle mongodb base types such as BaseDict and BaseList. The filter will call a helper function to recursively convert BaseDict and BaseList to python dict and list respectively. Fixes #4700.