Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 20.04 (focal) support #700

Merged
merged 11 commits into from
May 11, 2021
Merged

Add Ubuntu 20.04 (focal) support #700

merged 11 commits into from
May 11, 2021

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented May 6, 2021

No description provided.

@nzlosh
Copy link
Contributor Author

nzlosh commented May 7, 2021

This PR is part of StackStorm/community#68. The packages for focal appear to be building correctly now.

Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

scripts/st2bootstrap-deb.sh Show resolved Hide resolved
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for tidy up on those pre-Xenial ifs as well.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's incredible work here 👍 Thanks a lot!

Provided several comments to address before merging.

packages/st2/debian/rules Outdated Show resolved Hide resolved
scripts/st2_bootstrap.sh Outdated Show resolved Hide resolved
scripts/st2bootstrap-deb.sh Show resolved Hide resolved
scripts/st2bootstrap-deb.sh Show resolved Hide resolved
README.md Show resolved Hide resolved
@arm4b arm4b added the feature label May 9, 2021
@nzlosh
Copy link
Contributor Author

nzlosh commented May 10, 2021

The tests are failing because the focal packagingbuild image isn't updated with the upstream fix using the python3.8-venv debian package.

@arm4b
Copy link
Member

arm4b commented May 10, 2021

The updated Docker image should be ready now per https://hub.docker.com/r/stackstorm/packagingbuild/tags?page=1&ordering=last_updated Committing the review changes should help to re-trigger the build next.

scripts/st2_bootstrap.sh Outdated Show resolved Hide resolved
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Thanks again for the hard work here!

@arm4b arm4b merged commit e4f96f1 into StackStorm:master May 11, 2021
@nzlosh nzlosh deleted the u2004 branch May 11, 2021 20:35
@arm4b
Copy link
Member

arm4b commented May 11, 2021

FYI this should be installable now from the staging-unstable packages with the following one-liner command:

bash <(curl -sSL https://stackstorm.com/packages/install.sh) --user=st2admin --password=Ch@ngeMe --staging --unstable

@arm4b
Copy link
Member

arm4b commented May 11, 2021

Which is currently failing on MongoDB.

Looks like we need to ensure we're installing Mongo 4.4 for U20 here:

20210511T210627+0000 Warning: apt-key output should not be parsed (stdout is not a terminal)
20210511T210628+0000 OK
20210511T210628+0000 deb http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.0 multiverse
20210511T210628+0000 Hit:1 http://archive.ubuntu.com/ubuntu focal InRelease
20210511T210629+0000 Hit:2 http://archive.ubuntu.com/ubuntu focal-updates InRelease
20210511T210629+0000 Hit:3 http://archive.ubuntu.com/ubuntu focal-backports InRelease
20210511T210629+0000 Hit:4 http://security.ubuntu.com/ubuntu focal-security InRelease
20210511T210629+0000 Ign:5 http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.0 InRelease
20210511T210629+0000 Err:6 http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.0 Release
20210511T210629+0000   404  Not Found [IP: 52.85.104.74 80]
20210511T210630+0000 Reading package lists...
20210511T210630+0000 E: The repository 'http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.0 Release' does not have a Release file.
20210511T210630+0000 ############### ERROR ###############
20210511T210630+0000 # Failed on Install st2 dependencies (MongoDB) #
20210511T210630+0000 #####################################

@nzlosh
Copy link
Contributor Author

nzlosh commented May 12, 2021

PR for focal mongo 4.4 fix #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants