-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 20.04 (focal) support #700
Conversation
This PR is part of StackStorm/community#68. The packages for focal appear to be building correctly now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for tidy up on those pre-Xenial ifs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's incredible work here 👍 Thanks a lot!
Provided several comments to address before merging.
The tests are failing because the focal packagingbuild image isn't updated with the upstream fix using the |
The updated Docker image should be ready now per https://hub.docker.com/r/stackstorm/packagingbuild/tags?page=1&ordering=last_updated Committing the review changes should help to re-trigger the build next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Thanks again for the hard work here!
FYI this should be installable now from the
|
Which is currently failing on MongoDB. Looks like we need to ensure we're installing Mongo
|
PR for focal mongo 4.4 fix #702 |
No description provided.